OK CR, based on my looking at it last night as I promised ...


As previously mentioned, the buffing routine is one of the worst I've ever seen. I know from our chat that the timers are majorly screwed up in the program, but there HAS to be a way to fix them so it recognizes current buffs without having to REbuff you (especially if you have more than half a cycle left on you - wasteful of comps AND time). This includes DEATHS. When you die, if you don't restart the darn thing - it does not RECOGNIZE you have died and its little timer just continues on its merry way.


I noticed last night it does not always recognize that you may have low health needing its attention when fighting. I died last night because it did not heal ME in favor of attacking a baddie. Yes, I could have overridden it, but I was testing it as promised and did not want to interfere with its function. I'm pleased to report my lifestone is where I left it last, and in good shape!!


The program does NOT "refill" your H/S/M after finishing off monsters. Now I'll be honest, this was something ElTank did that sometimes I found annoying, but I never had a problem going into battle with perhaps half health because of it. Not sure what in the programming controls this, but it really needs to be looked at.


I received "WARNING: [Engine] Busy Timeout - resetting combat flags" a couple times when testing it out. What the heck is that?


As far as the interface goes, I'd remove references to the items removed from the program, perhaps make a bit more user-friendly "help" for things (or just tad more explanation on tabs) and it would be ok. Or perhaps a secondary download could be provided for a "user manual"?


Don't bother with routing or quest timers - to be honest, Digero has those pretty much perfected in a couple of his plugs (I use them both all the time). Adding MORE stuff is only going to increase the lag factor involved. I've proven it for myself ... I can run several "smaller" plugs with less lag than I have with ElTank (sorry Elgar, but it is true) - but have learned to play with the additional lag. I don't auto loot stuff, so cannot advise there. It's BIGGEST issue, as I see it, is anything having to do with the buffing routines (which you already knew). I'd focus on that, and to be honest, it seems pretty solid other than that. I DO like the fact that when it IS buffing you, it is VERY easy to override the buffs to attack something going after you (it did not do that) simply by hitting the appropriate spell key to do so. I was kinda under the impression it would do that itself, when it didn't, a couple quick keystrokes killed the baddy, LT finished buffing me, and all was good. There seems to be a lot of stuff on the interface that isn't really needed ...

 

-----signature-----

I like Lt just the way it is, been using it so long. C'r and team does a good job.

Brutal:

A Comp Hud wouldn't be a big deal I don't think. I'd honestly like to hold off on that idea until Decal finishes up their new DirectX/HUD related stuff since there may require a rewrite of that system when it happens. As far as quest timers and route finding, I can tell you know that won't happen. Digero's Quest Timer and GoArrow does a wonderful job of those already, and it would take away the main focus of Lifetank which is primarily combat. We're all about those other cool features, but it's too much work to reinvent something that someone else has already written and perfected... especially when there are other parts of the plugin still lacking we'd like to improve. Also, the BS2 corpse tracking may be a possibility. I would like to incorporate a part of the Spies plugin into Lifetank (minus a few of Spies specialized features) to help with tracking of such things.


The buffing system we are painfully aware of. None of us have really liked the methods that it uses to buff. Tracking buffs by timer is much more efficient and is something we've been casually looking in to lately. Tracking Item Buffs never crossed my mind, but now that it's mentioned, I'm not sure I can think of a good way to do that (besides assume they're on the same timer as your regular buffs as you suggested Maddy if I interpreted that correctly).


Also, the looting system we also know could use an overhaul. Each and every item goes through a metric ton of filters before it gets picked up, saved, salvaged, etc. We believe this is one reason looting tends to be slow. Although I don't believe we have an idea of where to start on it yet, it is something on the back burner that we'd like to update first.


As far as I can remember though, these are really the bigger parts of the plugin that could use an overhaul. Everything else for the most part is just tweaking (but correct me if I'm wrong =P )


Thanks for the input everyone. It's hard to keep a plugin on it's feet when you don't know what the users want... so this helps a good bit =)


-C

 

-----signature-----

<< I'm not sure I can think of a good way to do that (besides assume they're on the same timer as your regular buffs as you suggested Maddy if I interpreted that correctly). >>


That is correct. Or as I also suggested you could have a timer that fires once a minute (or faster). You store the the item GUID and the length of time of the buff, this allows for different spell levels, augmentations, etc. Then every time your timer fires you deduct a minute from the time. If you save this data when you exit then you can track them when you log back in with that character. So would mean saving theGUID of the player too.

 

-----signature-----

Item buffs:

1) Have LTx watch for buffs being cast on an item owned by the player, whether the buffs are cast by LTx or by the player.

2) Calculate the duration of the buff based on the level of the spell cast and the spell duration augmentations on the player (unless they were cast by someone else, in which case assume no augs).

3) Keep track of when the spell will expire in terms of the character's age (You have played for 2 months, 7 days...), not the system clock.

4) When the player logs off, save the expiration time (not seconds remaining) for all items currently in the character's inventory. This will make it so the timers are still valid if the player then turns the plugin off, plays for a bit, then turns the plugin back on.


An alternative (I think this is how ElTank does it):

1-2) same.

3) Keep track of how many seconds are left on the spell.

4) When the player logs off, save the number of seconds remaining, as well as the character's age when he logged off.

5) When the player logs back on, only load the item buff timers if the character's current age is within some tolerance of his age when the data was saved (say 15 seconds).

 

-----signature-----

Ashake: The "Busy Timeout" you are seeing is when the macro tries to do something, and that action silently fails (IE: No error message from the server.) or something happens that shouldnt be happening, like the player exiting combat mode while the bot is attempting to cast for example.

Replex, all the instances when I received that message were during active combat, not buffing. I was in a corner in 125 eaters, watching carefully to see what the program was doing. Although I had no packet loss or excessive lag (for me), it acted like it was momentarily freezing, tossed out that message, then resumed. Was not sure what it was, so figured I'd toss it out for clarification. Thanks - I'll keep an eye on it again when testing it, and see if I can figure out exactly what might be causing it (thinking it might be something not readily apparent as I'm on dialup).


One more thing I forgot to mention CR - that I mentioned when we chatted. Remove the "unfriendly player" stuff - and instead make it report on allegiance members in the vicinity - similar to El Tank. This is REALLY nice in a dungeon, you can see if there are fellow members within your allegiance and such.


It would also be nice if the plug remembered various profiles saved, and offer a choice to other characters you may have. It's a pain to have to go through every time a new character is set up and have to spend the time to re-setup the program for that particular character. Since I have a profile for Ashante (was doing the main test on her), would be nice to be able to select that for Belle, for example, rather than have to fuss with setting it up for Belle all over again.

 

-----signature-----

If you change the buffing logic, please leave a legacy option, there are many spawns where the current buffing logic works better than an Eltank style buffing logic.

 

-----signature-----

Azrael, I assume you mean the "continuous buffing" option. The idea is not to get rid of it, just make it smarter

 

-----signature-----

I concur with C'R about adding in the quest timers and stuff.. Why turn LT into bloatware? Digero's Quest Timer is awesome, and I recommend it to everyone. And Go Arrow's not too shabby either. heh..

 

-----signature-----