1.0.8.9:
Changed looter black listing from id to name. This should prevent attempting to pick up every quest item that a timer may not be up.
Looter will no longer pick up items that surpass keep # amounts.
Ident items on left click now works as it should, only on left click.


I was going to get the target health/stam/mana stuff into ident today but I should prob take a small break from deal dev.. heh

I do want to work on documenting the filters and some of the new options.

After more testing of the issue I was having regarding not being able to use 'loose change' to buy Trade notes. You said try setting up a loot rule to sell pyreals. I created a rule that sells ObjectClass == Money coupled with a rule that buys ObjectClass == TradeNote && Value == 50000. This works, but has a bug. Magtools will continue to try to buy D notes even if you do not have sufficient funds to purchase the note. Saying "[VIT] Purchase complete." over and over until you close the vendor window.

I will do some further tests and report the findings.

Laieda

I'll look into that.

I'll also add the debug mode for the vendor where it just adds all your sell and all your buy items to the vendors window.. It's a real easy thing for me to throw in there.

The other thing on my todo is to add red requirement support to autopack.

I was looking through the code last night, and this struck me as odd.

// Ok, we didn't find a Keep # rule, lets search all Keep rules now.
foreach (WorldObject vendorObj in openVendor)
{
// Convert the vendor item into a VT GameItemInfo object
uTank2.LootPlugins.GameItemInfo itemInfo = uTank2.PluginCore.PC.FWorldTracker_GetWithVendorObjectTemplateID(vendorObj.Id);

if (itemInfo == null)
{
Debug.WriteToChat("AutoBuySell.GetBuyItem(), itemInfo == null for " + vendorObj.Name);
continue;
}

// Get the loot profile result for this object
// result.IsNoLoot will always be false
uTank2.LootPlugins.LootAction result = looter.GetLootDecision(itemInfo);

if (!result.IsKeep)
continue;

// Ok, we need to buy some of this item, how many should we buy?
ln 247 buyAmount = 5000;

return vendorObj;
}

Line Number 247 above sets the buyAmount to 5000. However; on V's wiki it says this "Enter the number of items you would like to buy under Max buy. To buy as many as possible, enter -1. " So my hypothesis is it's not actually stuck in and endless loop. I think it's just going to try to buy 5000 Notes. I'm going to test this by changing that to buyAmount = -1. I suspect there is code in the Item tool that automatically stops after you have insufficient funds to buy said item.

I limit it to no more than 5000 per iteration. You can only add 5000 items to a vendor window. If you try to add more the vendor tells you with red text up top that says "I can't possibly add any more" or something like that.

So, the macro will buy the 5000, then the next iteration it will try to buy another 5000, etc.. but the item tool will only buy what you can afford regardless.

Okay. I tested the -1 buyAmount. It won't buy at all.

I've shifted my attention to the KickOffBuySell() function. Maybe it just needs to check to see if it has enough money to purchase and exit the loop if there is not.

Have you tried using item tool and setting pyreals as the sell item there?

No. I'll try it and see what I get.

Okay. I added some debugging code so I could see what was going on behind the scenes.

I'm not sure why Mag-Tools kicked in on a vendor that I don't have a profile for when I used the Go button on VIT, but it did. EDIT: This may have occurred because I did not completely log out of AC. I'll test it again after logging completely out.
This readout is where Mag-Tools went through it's KickOffBuySell() when I clicked the Go button:
21:30:08 <{Mag-Tools}>: Vendor's buy rate: 0.8
21:30:08 <{Mag-Tools}>: Vendor's sell rate: 1.8
21:30:08 <{Mag-Tools}>: DEBUG: Trade Note (50,000)
21:30:08 <{Mag-Tools}>: Game Data Flags1: 2125849
21:30:08 <{Mag-Tools}>: Trying to buy 5000 Trade Note (50,000) and sell Pyreal
21:30:08 <{Mag-Tools}>: Transaction was a Success.
21:30:08 [VIT] Purchase complete.

After disabling the Auto Buy/Sell Feature in Magtools I tried VIT again. I told it to buy 5 Dnotes and Sell Pyreal (Note: I only have 54k pyreal, not enough to buy even one Dnote)

The result:

21:31:23 [VIT] Purchase complete.

It only iterated one time, but when I had Mag-Tools' Auto Buy/Sell enabled. I pressed go (with 5 in the Max buy box of VIT) and it started looping over and over again.

I was correct. Apparently when I didn't log out completely I left some Event handlers assigned or something.